Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MSA] Fix loading from previous config #1246

Merged
merged 1 commit into from
May 13, 2022
Merged

[MSA] Fix loading from previous config #1246

merged 1 commit into from
May 13, 2022

Conversation

DLu
Copy link
Contributor

@DLu DLu commented May 13, 2022 •
edited
Loading

Description

I poorly documented the logic here, so I screwed up the reimplementation in a previous PR (#1212)

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@mergify
Copy link

mergify bot commented May 13, 2022

Please target the main branch for development, we will backport the changes to feature/msa for you if approved and if they don't break API.

@codecov
Copy link

codecov bot commented May 13, 2022

Codecov Report

Merging #1246 (8101b12) into feature/msa (f12f156) will increase coverage by 2.15%.
The diff coverage is 63.31%.

@@               Coverage Diff               @@
##           feature/msa    #1246      +/-   ##
===============================================
+ Coverage        59.13%   61.27%   +2.15%     
===============================================
  Files              275      274       -1     
  Lines            23732    24925    +1193     
===============================================
+ Hits             14032    15271    +1239     
+ Misses            9700     9654      -46
Impacted Files Coverage Δ
...lude/moveit/collision_detection/collision_matrix.h 100.00% <ø> (ø)
...llision_detection/src/collision_octomap_filter.cpp 0.00% <0.00%> (ø)
...src/bullet_integration/bullet_cast_bvh_manager.cpp 51.43% <0.00%> (+0.71%) ⬆️
...bullet_integration/bullet_discrete_bvh_manager.cpp 50.00% <0.00%> (-3.84%) ⬇️
...sion_distance_field/collision_env_distance_field.h 4.77% <ø> (+0.22%) ⬆️
...lision_distance_field/src/collision_env_hybrid.cpp 0.00% <0.00%> (ø)
...ene/include/moveit/planning_scene/planning_scene.h 43.55% <0.00%> (-6.45%) ⬇️
...bot_state/include/moveit/robot_state/robot_state.h 89.96% <ø> (+8.05%) ⬆️
...processing/src/iterative_time_parameterization.cpp 91.99% <0.00%> (-1.25%) ⬇️
...e/moveit/ompl_interface/planning_context_manager.h 100.00% <ø> (ø)
... and 243 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 380a79a...8101b12. Read the comment docs.

@vatanaksoytezer vatanaksoytezer merged commit ad6d401 into moveit:feature/msa May 13, 2022
@DLu DLu deleted the msa_fix_yaml branch May 13, 2022 17:04
DLu added a commit to DLu/moveit2 that referenced this pull request May 19, 2022
@DLu
[MSA] Fix loading from previous config (moveit#1246)
489664f
DLu added a commit to DLu/moveit2 that referenced this pull request May 19, 2022
@DLu
[MSA] Fix loading from previous config (moveit#1246)
66c17bf
vatanaksoytezer pushed a commit that referenced this pull request May 25, 2022
@DLu
[MSA] Fix loading from previous config (#1246)
b9e1ee3
vatanaksoytezer pushed a commit that referenced this pull request May 31, 2022
@DLu
[MSA] Fix loading from previous config (#1246)
92c9ede
vatanaksoytezer pushed a commit that referenced this pull request May 31, 2022
@DLu
[MSA] Fix loading from previous config (#1246)
96781aa
DLu added a commit to DLu/moveit2 that referenced this pull request Jun 13, 2022
@DLu
[MSA] Fix loading from previous config (moveit#1246)
229f6a8
DLu added a commit to DLu/moveit2 that referenced this pull request Jun 13, 2022
@DLu
[MSA] Fix loading from previous config (moveit#1246)
667e78e
vatanaksoytezer pushed a commit that referenced this pull request Jun 14, 2022
@DLu
[MSA] Fix loading from previous config (#1246)
a2b5204
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vatanaksoytezer vatanaksoytezer vatanaksoytezer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DLu @vatanaksoytezer